View Issue Details

IDProjectCategoryView StatusLast Update
0000289Medieval EngineersBugpublic2022-04-22 20:34
Reportergwindalmir Assigned Togwindalmir  
PriorityhighSeveritymajorReproducibilityhave not tried
Status assignedResolutionopen 
PlatformWindowsOS2016 1607OS Version14393
Product Version0.7.3.33D4BB 
Summary0000289: [DS] Crash: System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
Description

Gwindalmir: this is a clone of 0000212 to handle the InvalidOperationException separately from the auto-save failure. 0000212 is now for the auto-save failure.

See attached logfile.
Not a crash, but an exception while the server tried to do an autosave (see line 8121). After that, no autosaves ever happened again. The server crashed eventually and hours of progress went down the drain.

TagsSession

Relationships

related to 0000212 closedgwindalmir [DS] Crash: System.InvalidOperationException exception causes auto-save to fail and stop working  

Activities

shad

2022-04-11 07:44

reporter  

shad

2022-04-22 20:19

reporter   #~0000205

gwindalmir

2022-04-22 20:19

administrator   #~0000206

So, it looks like there's two issues:

  1. Voxel parsing isn't threadsafe
  2. The saving process creates a lock file, but it's not removed in the case of an error.

As a workaround, if this happens again, you should be able to delete the "save.lock" file in the save folder to resume auto-saving.

gwindalmir

2022-04-22 20:34

administrator   #~0000208

Last edited: 2022-04-22 20:34

To clarify my previous comment above, the issue isn't voxels after all.
The master entity list (MyScene.Entities), is being accessed in a non-thread-safe manner.

Issue History

Date Modified Username Field Change
2022-04-22 20:19 gwindalmir New Issue
2022-04-22 20:19 gwindalmir Status new => assigned
2022-04-22 20:19 gwindalmir Assigned To => gwindalmir
2022-04-22 20:19 gwindalmir Tag Attached: Session
2022-04-22 20:19 gwindalmir Issue generated from: 0000212
2022-04-22 20:19 gwindalmir Note Added: 0000205
2022-04-22 20:19 gwindalmir Note Added: 0000206
2022-04-22 20:19 gwindalmir Relationship added related to 0000212
2022-04-22 20:34 gwindalmir Note Added: 0000208
2022-04-22 20:34 gwindalmir Note Edited: 0000208